-
Notifications
You must be signed in to change notification settings - Fork 700
[ci] Add DSv3 SimpleFSDP auto_bucketing to h100 ci jobs #2347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
tests/integration_tests/__init__.py
Outdated
| ngpu: int = 4 | ||
| disabled: bool = False | ||
| skip_rocm_test: bool = False | ||
| config_file: str | None = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you have to add this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I tried to avoid it, but by default it using different toml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we designed the last version, we explicitly avoid having a config_file field, but choose to override on top of the base_config.toml, as they share most of the fields between the base_config and other debug model configs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SG. It seems CI failed for a different reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, smth with nvlink sharp that I have seen without this change.
adb164a to
bf208bf
Compare
Adding DSv3 SimpleFSDP + inductor auto_bucketing passes to H100 CI.
We need H100 to go through grouped_mm path.
Testing:
Originally I wanted to add this CI to AutoParallel. But we can not do it as it runs on A100 and goes through non-groupedmm moe part.